Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template for performance testing with custom Kubernetes version #5342

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add template for performance testing with custom Kubernetes version #5342

merged 1 commit into from
Jan 15, 2025

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Dec 17, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:Add template for performance testing with custom Kubernetes version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2024
@Jont828 Jont828 mentioned this pull request Dec 17, 2024
Open
4 tasks
@Jont828 Jont828 force-pushed the entrypoint-custom-builds branch 2 times, most recently from f60ccc6 to 007ef8e Compare December 17, 2024 02:25
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (00dfab1) to head (9b33af5).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5342   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files         272      272           
  Lines       29401    29401           
=======================================
  Hits        15417    15417           
  Misses      13178    13178           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jont828
Copy link
Contributor Author

Jont828 commented Dec 17, 2024

/test ls

@k8s-ci-robot
Copy link
Contributor

@Jont828: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-azure-apiversion-upgrade
  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-ci-entrypoint
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-e2e-aks
  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-azure-apidiff
  • /test pull-cluster-api-provider-azure-apiserver-ilb
  • /test pull-cluster-api-provider-azure-capi-e2e
  • /test pull-cluster-api-provider-azure-conformance
  • /test pull-cluster-api-provider-azure-conformance-custom-builds
  • /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-e2e-optional
  • /test pull-cluster-api-provider-azure-e2e-workload-upgrade
  • /test pull-cluster-api-provider-azure-load-test-custom-builds
  • /test pull-cluster-api-provider-azure-windows-custom-builds
  • /test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-ci-entrypoint
  • pull-cluster-api-provider-azure-conformance
  • pull-cluster-api-provider-azure-conformance-custom-builds
  • pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
  • pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
  • pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify
  • pull-cluster-api-provider-azure-windows-custom-builds
  • pull-cluster-api-provider-azure-windows-with-ci-artifacts

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Jont828 Jont828 force-pushed the entrypoint-custom-builds branch 2 times, most recently from 5a0efc2 to e05f164 Compare December 17, 2024 02:59
@Jont828
Copy link
Contributor Author

Jont828 commented Dec 17, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

2 similar comments
@Jont828
Copy link
Contributor Author

Jont828 commented Dec 17, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Dec 17, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828 Jont828 force-pushed the entrypoint-custom-builds branch from dd8b409 to d321deb Compare December 17, 2024 18:04
@Jont828
Copy link
Contributor Author

Jont828 commented Dec 17, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

4 similar comments
@Jont828
Copy link
Contributor Author

Jont828 commented Dec 18, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Dec 18, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Dec 18, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Dec 19, 2024

/test pull-cluster-api-provider-azure-load-test-custom-builds

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2025
@Jont828 Jont828 force-pushed the entrypoint-custom-builds branch from 4e15c40 to 0a0569d Compare January 3, 2025 22:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2025
@Jont828
Copy link
Contributor Author

Jont828 commented Jan 3, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 10, 2025
mboersma
mboersma reviewed Jan 10, 2025
View reviewed changes
scripts/aks-as-mgmt.sh Outdated Show resolved Hide resolved
scripts/aks-as-mgmt.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
templates/test/dev/cluster-template-custom-builds-load.yaml Show resolved Hide resolved
templates/test/dev/cluster-template-custom-builds-load.yaml Show resolved Hide resolved
templates/test/dev/cluster-template-custom-builds-load.yaml Show resolved Hide resolved
templates/test/dev/cluster-template-custom-builds-load.yaml Show resolved Hide resolved
templates/test/dev/cluster-template-custom-builds-load.yaml Show resolved Hide resolved
templates/test/dev/cluster-template-custom-builds-load.yaml Show resolved Hide resolved
templates/test/dev/cluster-template-custom-builds-load.yaml Show resolved Hide resolved
@mboersma mboersma requested review from jackfrancis and removed request for nojnhuh and marosset January 10, 2025 15:46
@jackfrancis
Copy link
Contributor

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828 Jont828 force-pushed the entrypoint-custom-builds branch from 77cfeb6 to 78160ee Compare January 13, 2025 18:56
@Jont828
Copy link
Contributor Author

Jont828 commented Jan 13, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

1 similar comment
@Jont828
Copy link
Contributor Author

Jont828 commented Jan 13, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 13, 2025

Trying it off of perf-tests main to see if the namespace issue still exists

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 14, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

4 similar comments
@Jont828
Copy link
Contributor Author

Jont828 commented Jan 14, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 14, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 14, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 14, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828 Jont828 force-pushed the entrypoint-custom-builds branch from cdbfad7 to bc07b30 Compare January 14, 2025 23:01
@Jont828
Copy link
Contributor Author

Jont828 commented Jan 14, 2025

Okay hopefully this should be passing now, we just want to get some runs to verify that it works :)

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 14, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 15, 2025

Load test passed:
/test pull-cluster-api-provider-azure-load-test-custom-builds

Normal e2e failed, rerun to see if flake:
/test pull-cluster-api-provider-azure-e2e

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 15, 2025

/test pull-cluster-api-provider-azure-load-test-custom-builds

@Jont828 Jont828 force-pushed the entrypoint-custom-builds branch from bc07b30 to 9b33af5 Compare January 15, 2025 22:24
jackfrancis
jackfrancis approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 85fd731817e04ef08bdb962766a5b56b5df4488c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 27c0476 into kubernetes-sigs:main Jan 15, 2025
25 of 29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma left review comments

@jackfrancis jackfrancis jackfrancis approved these changes

Assignees

@jackfrancis jackfrancis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@Jont828 @k8s-ci-robot @jackfrancis @mboersma